Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Manager monitor, simplify and modularise config #21

Merged
merged 3 commits into from
Jun 8, 2022

Conversation

bertsky
Copy link
Member

@bertsky bertsky commented Jun 7, 2022

It seems to work (including the Monitor), but I cannot see anything on the Manager logs.

bertsky and others added 3 commits June 7, 2022 13:48
- symlink to Kitodo app compose file
- encapsulate selection of compose files in Makefile
- move top-level compose file to Manager
- create top-level compose file that `extends` Manager/Controller
- select between standalone and managed mode by not/including
  compose file for Controller
- delegate all remaining config to variables
- place defaults in `.env`
- simplify Makefile rules, add `config` and `status` targets
- update README
@markusweigelt
Copy link
Collaborator

markusweigelt commented Jun 8, 2022

For the time being, I have nothing to complain about. Can you still fix the conflicts and rebase to the main?

@markusweigelt
Copy link
Collaborator

Oh I think it is still necessary to update the submodules.

@bertsky
Copy link
Member Author

bertsky commented Jun 8, 2022

Can you still fix the conflicts and rebase to the main?

I don't understand. The PR does not show any conflicts. Also, I cannot do anything, because I don't have any permissions.

Oh I think it is still necessary to update the submodules.

What do you mean? The PR does update ocrd_manager already. Not to your merge though, only to slub/ocrd_manager#20. So do you want me to update to the current master?

@markusweigelt
Copy link
Collaborator

Can you still fix the conflicts and rebase to the main?

I don't understand. The PR does not show any conflicts. Also, I cannot do anything, because I don't have any permissions.

In my case i selected "Rebase and merge" on the PR so following problem is shown "This branch cannot be rebased due to conflicts". When i change to "Merge pull request" the are no conflicts. Ok so i will select the last to merge and not to rebase.

Oh I think it is still necessary to update the submodules.

What do you mean? The PR does update ocrd_manager already. Not to your merge though, only to markusweigelt/ocrd_manager#20. So do you want me to update to the current master?

I meaned the submodule reference to the head of ocrd_manager. sorry i read over the changes in the submodule :/

@markusweigelt markusweigelt merged commit ae46c54 into slub:main Jun 8, 2022
@bertsky bertsky deleted the add-manager-monitor branch December 14, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants