Add monitor jobs and logs #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README.md
Outdated
| @@ -240,9 +241,9 @@ the UID and GID of the Controller and Manager in our Makefile are taken from the | |||
| Shell environment variables take precedence over `.env` file variables in Docker Compose. | |||
| For example: | |||
|
|
|||
| export CONTROLLER_ENV_UID=$(id -u) CONTROLLER_HOST=ocrserver | |||
| export CONTROLLER_ENV_UID=$(id -u) CONTROLLER_HOST=ocrserver CONTROLLER_PORT_SSH=8022 | |||
There was a problem hiding this comment.
I renamed port to CONTROLLER_SSH_PORT cause it is a more contextual way.
There was a problem hiding this comment.
Where? Manager still uses CONTROLLER_SSH_PORT, and Controller still does not use that variable at all.
There was a problem hiding this comment.
Sry, understood! (Typo on my side.)
markusweigelt
approved these changes
Jul 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.