Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve kitodo process ocr script to support workflow, script and lan… #80

Merged
merged 6 commits into from
Jun 16, 2023

Conversation

markusweigelt
Copy link
Collaborator

@markusweigelt markusweigelt commented Jun 14, 2023

…guage as parameter

  • Support named parameters
  • Remove support of workflow file in process directory
  • Adjust ssh command to forward parameter values to manager script

@markusweigelt markusweigelt requested a review from bertsky June 14, 2023 09:56
Copy link
Member

@bertsky bertsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Splendid!

Also update the Kitodo submodule (so the lang and script gets passed from the metadata in the correct way)?

@markusweigelt
Copy link
Collaborator Author

No this submodule only contains the build mechanim to build and run the Kitodo.Production image. Our ocrd-main branch in my repository should be updated to provide new functionalities but it works also without IMO.

@markusweigelt markusweigelt requested a review from bertsky June 16, 2023 09:44
@markusweigelt markusweigelt merged commit 84b7e54 into main Jun 16, 2023
@markusweigelt markusweigelt deleted the improve-process-images branch June 16, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants