Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile: symlink scripts #51

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Dockerfile: symlink scripts #51

merged 1 commit into from
Mar 6, 2023

Conversation

bertsky
Copy link
Member

@bertsky bertsky commented Mar 6, 2023

fixes #50

@@ -65,6 +65,9 @@ RUN echo AllowUsers ocrd >> /etc/ssh/sshd_config
RUN echo "cd /data" >> /etc/profile
RUN /usr/sbin/sshd -t # check the validity of the configuration file and sanity of the keys
COPY *.sh /usr/bin/
RUN cd /usr/bin; \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
RUN cd /usr/bin; \
RUN cd /usr/bin \

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that would not work – you need a cmd separator

@@ -65,6 +65,9 @@ RUN echo AllowUsers ocrd >> /etc/ssh/sshd_config
RUN echo "cd /data" >> /etc/profile
RUN /usr/sbin/sshd -t # check the validity of the configuration file and sanity of the keys
COPY *.sh /usr/bin/
RUN cd /usr/bin; \
ln -fs process_mets.sh for_presentation.sh; \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ln -fs process_mets.sh for_presentation.sh; \
ln -fs process_mets.sh for_presentation.sh \

Copy link
Collaborator

@markusweigelt markusweigelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes you are right! 👍🏻

@markusweigelt markusweigelt merged commit e2eb925 into main Mar 6, 2023
@markusweigelt markusweigelt deleted the symlink-scripts branch March 6, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Symlink for_production.sh and for_production.sh
2 participants