Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements env file #1

Merged
merged 1 commit into from
Mar 1, 2023
Merged

Improvements env file #1

merged 1 commit into from
Mar 1, 2023

Conversation

markusweigelt
Copy link
Collaborator

@markusweigelt markusweigelt commented Feb 27, 2023 •
edited
Loading

  • Rename env file similar to the OCR-D Manager repo
  • Remove unused and add necessary env's

bertsky
bertsky approved these changes Feb 27, 2023
View reviewed changes
Copy link
Member

@bertsky bertsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

Perhaps we should also improve the Readme a little: In the section Running, after the table explaining the required envvars, we can point to .env.example, showing how it can be copied to .env (for docker compose) or sourced (for make run).

@markusweigelt markusweigelt merged commit ce87753 into main Mar 1, 2023
@markusweigelt markusweigelt deleted the improvements-new-repo branch March 1, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertsky bertsky bertsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markusweigelt @bertsky