Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port process spawning to asyncio #21

Merged
merged 1 commit into from
Mar 28, 2023
Merged

Port process spawning to asyncio #21

merged 1 commit into from
Mar 28, 2023

Conversation

SvenMarcus
Copy link
Collaborator

Spawns browser subprocesses with asyncio instead of using the blocking subprocess module

@SvenMarcus SvenMarcus added the enhancement New feature or request label Mar 23, 2023
@markusweigelt
Copy link
Collaborator

Can you rebase or merge the main branch into this branch?

bertsky
bertsky approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@bertsky bertsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markusweigelt markusweigelt merged commit 5c66273 into slub:main Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertsky bertsky bertsky approved these changes

@markusweigelt markusweigelt Awaiting requested review from markusweigelt

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SvenMarcus @markusweigelt @bertsky