Improved implementation to kill a job #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SvenMarcus
requested changes
Aug 17, 2023
Good catch! |
SvenMarcus
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation was not sufficient for killing jobs.
The invocation using the host
ocrd-managerdid not work, because the browser sends requests from the host, and herelocalhostwas the correct host.However, this leads to a CORS problem in the browser.
Therefore, the monitor was extended with the URL
/jobs/kill/%PID%and sends an HTTP request to the manager. From the monitor's perspective, the manager can be found under the hostocrd-manager.The URL to the manager's endpoint is passed to the monitor as an environment variable when it starts.