Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiTx logic problem - switch ON TX but not OFF SVXLInk v1.8 #673

Open
sp2ong opened this issue May 22, 2024 · 13 comments
Open

MultiTx logic problem - switch ON TX but not OFF SVXLInk v1.8 #673

sp2ong opened this issue May 22, 2024 · 13 comments

Comments

@sp2ong
Copy link

sp2ong commented May 22, 2024

We have used in our Fm Network SVXlink version 1.8 and and we are seeing a serious problem with the use of MultiTx

In many cases, after analyzing the logs, when in the same second there is "Talker start ..." and MultiTx Turning the transmitter ON and then in the same second we have "Talker stop ..." (see the sample log piece below) MutliTx will never turns off the transmitter, i.e. MultiTx does not appear ... OFF
While in the case of RepeaterLogic, when someone sends something and opens the repeater receiver, after this action MultiTx is OFF, but in the case of a Simplex Node, only the svxlink reset remains. On the other hand, no one monitors the duplex or simplex repeater 24 hours a day when hangs while transmitting, so this is a problem. This phenomenon occurs when activity comes from svxreflector.

I don't really know the code mechanism on what basis MultiTX decides to turn MutliTx off (OFF), but you can see from the logs that this phenomenon occurs when the time of the Talker start, MutliTx ON, Talker stop phenomena are in the same second (it probably differs in milliseconds, but in the log we have the same times for these 3 phenomena

If the problem could be solved, it would be very helpful for us when we use MultiTx mode

2024-05-20 21:30:10 ReflectorLogic: Talker start on TG #260: SR6AA
2024-05-20 21:30:10 MultiTx : Turning the transmitter ON
2024-05-20 21:30:10 ReflectorLogic: Talker stop on TG #260: SR6AA
2024-05-20 21:31:33 ReflectorLogic: Node left: SP2ABC
2024-05-20 21:31:52 ReflectorLogic: Node joined: SR3SN
2024-05-20 21:32:15 ReflectorLogic: Node joined: SR2SWR

In section [SimplexLogic] or [RepeaterLogic] we use

TX=MultiTx

below section MultiTx and TxUDP which is used send via UDP audio

[MultiTx]
TYPE=Multi
TRANSMITTERS=Tx1,TxUDP

[TxUDP]
TX_ID=TU
TYPE=Local
AUDIO_DEV=udp:127.0.0.1:4300
LIMITER_THRESH=-6
AUDIO_CHANNEL=0
PTT_TYPE=NONE
TIMEOUT=7200

When we switch in SimplexLogic or RepeaterLogic from TX=MultiTx to TX=Tx1, this phenomenon does not occur, so it is clear that MultiTx has a problem

Best regards Waldek

@f5vmr
Copy link

f5vmr commented May 22, 2024 via email

@sp2ong
Copy link
Author

sp2ong commented May 22, 2024

Chris,

This phenomenon occurs when the activity from svxreflector is in the logs within the same second, when the Talker start, MutluTx ON and Talker stop process is spread over time, everything works correctly, but when these 3 elements are present in the same second in the log (they probably differ between are in milliseconds) MultiTx does not turn off the transmitters, the radio transmitter is especially important for us
This phenomenon does not occur on one node, but is observed on various nodes that have MltiTx on svxlink v1.8

@f5vmr
Copy link

f5vmr commented May 23, 2024 via email

@sp2ong
Copy link
Author

sp2ong commented May 23, 2024

As I wrote, this situation with MutliTx not being turned off occurs when activity comes from svxreflector, i.e. when someone via the network makes a short Talker start and Talker stop event and they are in the log in the same second as MutliTx ON and this phenomenon with PTT blocking occurs only when such situations happen via svxreflector often.
Blocking TX for UDP is not a problem, the problem for us is that the radio transmitter is turned on and it can be so long until there is no activity after this event, i.e. MultiTx On but no Mutlitx OFF
I wouldn't write about this problem if it was an isolated incident, but we have this problem on many nodes with SVXLink v1.8
I would like to know on what basis MultiTx makes the decision to turn it off, i.e. MultiTx OFF, is it based on the lack of a network audio stream or another mechanism because something causes it to not be able to close MultiTx OFF when such a phenomenon is Talker start and talker stop (i.e. network activity from the svxrefrlector ) takes place in a short time, practically in the same second

@f5vmr
Copy link

f5vmr commented May 23, 2024 via email

@sp2ong
Copy link
Author

sp2ong commented May 23, 2024

Yes, and I think that Tobias knows the intricacies of the code and information transfer paths so that MultiTx turns OFF if Talker sends the OFF status
You can see that this information is lost if the phenomenon is correct and at the same time the differences are in milliseconds and using MultiTx becomes a problem for us because it blocks radio transmitters and may be blocked for different time periods.

@f5vmr
Copy link

f5vmr commented May 23, 2024 via email

@sp2ong
Copy link
Author

sp2ong commented May 23, 2024

Chirs will write again

This phenomenon occurs when (look at time and seconds) it is in the same second

2024-05-20 21:30:10 ReflectorLogic: Talker start on TG #260: SR6AA
2024-05-20 21:30:10 MultiTx : Turning the transmitter ON
2024-05-20 21:30:10 ReflectorLogic: Talker stop on TG #260: SR6AA

if after this you have some activity, there is no problem, but when after this phenomenon there is no activity from the svxreflector, there is no MultiTX OFF, if there is no activity for 20 minutes, then there will be PTT ON on the transmitter for 20 minutes

73 Waldek

@sp2ong
Copy link
Author

sp2ong commented May 23, 2024

If it was a single phenomenon and on one node, I wouldn't write about it, but since we have this problem on many nodes, it is a repeatable phenomenon when we have Talker start, MultiTx ON, Talker stop from the svxreflector in the same second

@f5vmr
Copy link

f5vmr commented May 23, 2024 via email

@sp2ong
Copy link
Author

sp2ong commented May 23, 2024

Hm
Reading this file


/**
@brief	 Talker stop TCP network message V1
@author  Tobias Blomberg / SM0SVX
@date    2017-02-12

This message is sent by the server to the clients to inform about that the
specified node has stopped talking. Note that audio packets may be received
even after this message has been received. It should be used for informational
purposes only.

It turns out that the "Talker stop" message is not an element used to disable PTT, so there is something else in the code that causes the transmitter to turn on and off sequence to fail to properly close in this situation.

@f5vmr
Copy link

f5vmr commented May 23, 2024 via email

@sp2ong
Copy link
Author

sp2ong commented May 24, 2024

It seems that this is something related to the use of MultiTx logic, because when SimplexLogic or RepeaterLogic turns instead of MutliTx, we will only use Tx1, which is the PTT for the radio transmitter, these problems do not occur in the situations described in the previous posts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants