Added cheat: Stay in level after star

[Mode8fx]

Added a cheat that makes you stay in a level after collecting a star. You can hold L while collecting a star to temporarily disable this effect and leave the level. This cheat has no effect on Bowser keys, or stars that already make you stay in the level in the base game.

Also, if you have a better name than "Stay in level after star", be my guest. "Stay in level after getting a star (hold L to cancel)" doesn't fit in the cheat description.

EDIT: There is also a Non-Stop option that doesn't play any animation or dialog box, and even your momentum upon grabbing a star is uninterrupted. The game autosaves when you collect a star in this mode. Holding L still makes you exit the level as normal.

[GizmoTheGreen]

rather than (hold L to ignore cheat temporarily) can't you call the 100coin dialog box on every star instead when the cheat is active?

[Mode8fx]

That’s what this cheat is doing (except it’s the secret star dialog, not 100 coins). If you stay in the level, the “Wow, another power star! Would you like to save?” dialog pops up, so you can still save after each star.
The holding L part is there because it’s sometimes preferable to leave the level instead of having to pause and select Exit Course (like if you already got every star that’s currently obtainable, or you simply want to leave a level early).

[GizmoTheGreen]

Ah, My bad then.On May 24, 2020 15:20, GateGuy <notifications@github.com> wrote: That’s what this cheat is doing (except it’s the secret star dialog, not 100 coins). If you stay in the level, the “Wow, another power star! Would you like to save?” dialog pops up, so you can still save after each star. The holding L part is there because it’s sometimes preferable to leave the level instead of having to pause and select Exit Course (like if you already got every star that’s currently obtainable, or you simply want to leave a level early). —You are receiving this because you commented.Reply to this email directly, view it on GitHub, or unsubscribe.

[Plynthus]

Thank you for this one! I've had a lot of fun with this so far.
Hope it gets added to the nightly soon, I've been manually adding it to every build lately.

There is an issue when playing with bettercamera=1.
Any stars(except 100 coin stars) that you collect under water breaks the camera. At least if you save, haven't tried not saving after collecting.
Happened to me with every underwater star in Dire Dire Docks today.
Exiting level fixes it.

[Mode8fx]

Glad you like it!

I’ve noticed that bug too, even without BETTERCAMERA. But I didn’t know if that was a bug with this code, or if the game did that anyway. The only way to test it would be to get a 100 coin star underwater, but a lot of the coins in JRB crash my game since I play with NODRAWDISTANCE. I’ll play around with it today and see what’s causing the problem.

[Plynthus]

I’ve gotten 100 coin star in Jolly Roger Bay and Dire Dire Docks underwater and either broke the camera. Only the stars that normally would make you exit the level.

[GizmoTheGreen]

would it be possible to have the option of On, Non-stop, Off?
I seem some nonstop speedruns on youtube where there's no dialog at all, picking a star up is like getting a coin, no interrupt (what I thought this was at first)
ad only way to exit stage is die or startmenu :)

[Mode8fx]

I’ve gotten 100 coin star in Jolly Roger Bay and Dire Dire Docks underwater and either broke the camera. Only the stars that normally would make you exit the level.

In that case, I'll look into fixing it later today. I think I know what the problem is, so it shouldn't take too long.

would it be possible to have the option of On, Non-stop, Off?
I seem some nonstop speedruns on youtube where there's no dialog at all, picking a star up is like getting a coin, no interrupt (what I thought this was at first)
ad only way to exit stage is die or startmenu :)

I have another PR (#273) that removes the dialog, though it still plays an animation when you pick up a star.

[Mode8fx]

I just fixed the camera bug, so it should be ready to merge.

[Plynthus]

Thanks, it works great now! I just tested with 3 different stars.

[ShadowOne333]

If I may, I'd like to suggest having such feature as an option, rather than a cheat.
The difference might not be as obvious, but this doesn't seem as something that would be considered a cheat or "cheating", but more so like a proper feature.

If Achievements become a thing later on (and they check for cheats enabled or not), having this labelled as a cheat could harm that.

[Mode8fx]

Personally, I don't care either way, but I added it as a cheat just to be safe since it changes the game in a way that objectively benefits the player.

[GizmoTheGreen]

How about a commandline option? same as skip-intro, since it's useful for non-stop runs (youtube it).
--exit-level=on|off|prompt
default would be on (it exits level normally), prompt acts as 100coin star, and off = non-stop. exit level from start menu or death.

or maybe call it no-exit-level and invert on/off logic, maybe makes more sense?

[Mode8fx]

I'd rather not make it a command line option since those aren't as user-friendly as having an in-game setting (and you're screwed if you're playing on something like a Raspberry Pi). How about this: I'll keep it as a cheat for now, but when/if the "Other" menu option is added (#273), I can move it there and connect it to a config file option.

Also, I completely forgot about the non-stop option, that's really cool (I think I used it a long time ago). I'm busy until tomorrow night, but I'll work on adding it then.

[Mode8fx]

Nonstop is in! So it's ready to merge again (I probably should have changed this PR into a draft, but it doesn't matter now).