Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Press Start on the ending screen to reset the game #283

Open
wants to merge 5 commits into
base: nightly
Choose a base branch
from

Conversation

Mode8fx
Copy link
Contributor

@Mode8fx Mode8fx commented May 31, 2020

On the ending screen, pressing Start will cause the screen to slowly fade to black, stay black for a moment, then reset to the title screen.
I don't know if this should be in the actual game or a QOL define, but here it is anyway.

If you want to test this for yourself, add this to act_idle() in mario_actions_stationary.c:
if (m->controller->buttonPressed & L_TRIG) { level_trigger_warp(m, WARP_OP_CREDITS_END); }
... then press L while standing still to warp straight to the ending.

@rawr51919
Copy link
Contributor

perhaps making this happen automatically would be great

@Mode8fx
Copy link
Contributor Author

Mode8fx commented May 31, 2020

I could set a timer, but I feel like pressing start would be preferable. I think that's how it is in other Mario games, though I may be wrong.

@rawr51919
Copy link
Contributor

Perhaps this could be made into an option. How do you want to end the game? Press Start or wait? Options menu tweaks could allow for this.

@fgsfdsfgs
Copy link
Collaborator

That's a thought for when we implement compatflags or whatever.

@rawr51919
Copy link
Contributor

QOL_FIXES might like something like this. It's quite the convenience for when the game's right at the ending.

@Mode8fx
Copy link
Contributor Author

Mode8fx commented Jun 1, 2020

Is QOL_FIXES implemented yet?

@rawr51919
Copy link
Contributor

Is QOL_FIXES implemented yet?

Not yet, but it'll be soon. Most likely the devs are waiting for the next code refresh in order to

@Mode8fx
Copy link
Contributor Author

Mode8fx commented Jun 1, 2020

Got it, that makes sense.

@rawr51919
Copy link
Contributor

QOL_FIXES has undergone a revamp. PR #455 has the progress on this so far. Feel free to add any more things that needed a fix for 24+ years there

@Mode8fx
Copy link
Contributor Author

Mode8fx commented Feb 14, 2021

Let me know when QOL_FIXES is merged, then I'll change this PR to use it.

@rawr51919
Copy link
Contributor

rawr51919 commented Feb 14, 2021 via email

theclashingfritz referenced this pull request in djoslin0/sm64ex-coop Feb 22, 2023
quentin452 added a commit to quentin452/sm64ByCat that referenced this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants