-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Press Start on the ending screen to reset the game #283
base: nightly
Are you sure you want to change the base?
Conversation
Forgot to take this out
perhaps making this happen automatically would be great |
I could set a timer, but I feel like pressing start would be preferable. I think that's how it is in other Mario games, though I may be wrong. |
Perhaps this could be made into an option. How do you want to end the game? Press Start or wait? Options menu tweaks could allow for this. |
That's a thought for when we implement compatflags or whatever. |
QOL_FIXES might like something like this. It's quite the convenience for when the game's right at the ending. |
Is QOL_FIXES implemented yet? |
Not yet, but it'll be soon. Most likely the devs are waiting for the next code refresh in order to |
Got it, that makes sense. |
It only took three months to change two numbers :^)
QOL_FIXES has undergone a revamp. PR #455 has the progress on this so far. Feel free to add any more things that needed a fix for 24+ years there |
Let me know when QOL_FIXES is merged, then I'll change this PR to use it. |
Sure thingSent from my Galaxy
-------- Original message --------From: GateGuy <notifications@github.com> Date: 2021-02-14 7:56 p.m. (GMT-04:00) To: sm64pc/sm64ex <sm64ex@noreply.github.com> Cc: "Colton G. Rushton" <colton51919@gmail.com>, Comment <comment@noreply.github.com> Subject: Re: [sm64pc/sm64ex] Press Start on the ending screen to reset the
game (#283)
Let me know when QOL_FIXES is merged, then I'll change this PR to use it.
—You are receiving this because you commented.Reply to this email directly, view it on GitHub, or unsubscribe.
|
On the ending screen, pressing Start will cause the screen to slowly fade to black, stay black for a moment, then reset to the title screen.
I don't know if this should be in the actual game or a QOL define, but here it is anyway.
If you want to test this for yourself, add this to act_idle() in mario_actions_stationary.c:
if (m->controller->buttonPressed & L_TRIG) { level_trigger_warp(m, WARP_OP_CREDITS_END); }
... then press L while standing still to warp straight to the ending.