ProcessPipeline tracing and some tags #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tracing to ProcessPipeline, tag the command(s) as `db.statement` and improve tests
smacker
reviewed
Apr 10, 2019
smacker
reviewed
Apr 10, 2019
smacker
reviewed
Apr 10, 2019
smacker
reviewed
Apr 10, 2019
|
please remove adding commands values into tags. |
|
Most of it was fixed by @kmanco, I'll update the description of the PR to reflect the state of it. Once it's ready to merge, I can squash the commits if needed |
smacker
reviewed
Apr 11, 2019
otredis.go
Outdated
| "github.com/opentracing/opentracing-go/ext" | ||
| ) | ||
|
|
||
| // WrapRedisClient adds opentracing measurements for commands and returns cloned client |
There was a problem hiding this comment.
could you please return documentation for this function.
All public functions must be documented.
|
Please return the docstring for the exported function and it's good to go. |
Add documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2
Changes:
peer.addressspan.kind