Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config.getValueCollection() #63

Closed
dmlloyd opened this issue Dec 13, 2018 · 1 comment
Closed

Config.getValueCollection() #63

dmlloyd opened this issue Dec 13, 2018 · 1 comment

Comments

@dmlloyd
Copy link
Contributor

dmlloyd commented Dec 13, 2018

It would be great if the base Config interface had methods to get collections of single-valued items. The API could accept a function that accepts a size estimate and yields some kind of collection type.

I'll send up a PR as an example of how the API could look, if added on SmallRyeConfig.
dmlloyd added a commit to dmlloyd/smallrye-config that referenced this issue Dec 13, 2018
@dmlloyd
[smallrye#63] A multi-value config get operation
6a5cdf5
@dmlloyd dmlloyd mentioned this issue Dec 14, 2018
Merged
@jmesnil
Copy link
Contributor

jmesnil commented Dec 14, 2018

+1

The Config API only allows programmatic lookup of arrays (
https://github.com/eclipse/microprofile-config/blob/master/spec/src/main/asciidoc/converters.asciidoc#array-converters) while the CDI injection supports array, List and Set.

kenfinnigan added a commit that referenced this issue Dec 14, 2018
@kenfinnigan
Merge pull request #64 from dmlloyd/multi
8369341 
[#63] A multi-value config get operation
jmesnil added a commit to jmesnil/smallrye-config that referenced this issue Dec 14, 2018
@jmesnil
[smallrye#63] A multi-value config get operation
970f15d 
* add tests

issue: smallrye#63
@jmesnil jmesnil mentioned this issue Dec 14, 2018
Merged
kenfinnigan added a commit that referenced this issue Dec 14, 2018
@kenfinnigan
Merge pull request #65 from jmesnil/63_multi_value_collection
cc0fc35 
[#63] A multi-value config get operation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jmesnil @dmlloyd @kenfinnigan