prevent arithmetic overflow and reduce allocations in time conversions

[magicprinc]

See java.lang.Math#multiplyExact(long, long)

ArithmeticException can be thrown

and temporary Duration objects are created

[magicprinc]

The final version:

• doesn't create temporary Duration object
• doesn't suffer from ArithmeticException (long overflow)
• supports more ChronoUnit than before (e.g. MONTHS)

[Ladicek]

Good point, I didn't realize that. I generally think that overflow would be rare, so we could just wrap the Duration.toMillis() call in a try/catch and return Long.MAX_VALUE, but if we can avoid allocating, that's even better :-)

[Ladicek]

I removed the Thread.yield() call, because I haven't seen conclusive evidence that this is actually helpful. Do you have any benchmarks that motivated this change?

[magicprinc]

About Thread.yield():

I have made tests now, and it should be Thread.sleep(0) actually.

sleep(0) works and it allows thread interruption

sleep and onSpinWait are very strange methods in this aspect :-)

[Ladicek]

Thread.onSpinWait() would be a mistake here, the ThreadSleepDelay is not busy waiting / spinning.

If I understand correctly, you attempted to play nice in the cooperative multi-threading world of virtual threads, but I believe the retry strategy is not the right place for that. If the guarded logic is heavy on computations and monopolizes the carrier thread, it is its job to play nice.