Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: produce a no-dependencies shaded Mutiny jar #1613

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Conversation

jponge
Copy link
Member

@jponge jponge commented May 29, 2024

Ref: #1577

@jponge
Copy link
Member Author

jponge commented May 29, 2024

This shades and relocates JCTools and Smallrye Common Annotations. The JCTools .atomic. queue variants are removed as well as counters and maps.

On the sizes front the benefit isn't spectacular:

864K	implementation/target/mutiny-999-SNAPSHOT.jar
8.0K	/Users/jponge/.m2/repository/io/smallrye/common/smallrye-common-annotation/2.4.0/smallrye-common-annotation-2.4.0.jar
408K	/Users/jponge/.m2/repository/org/jctools/jctools-core/4.0.3/jctools-core-4.0.3.jar

1.1M	no-deps/target/mutiny-no-deps-999-SNAPSHOT.jar

@jponge jponge marked this pull request as draft May 30, 2024 13:57
no-deps/pom.xml Outdated Show resolved Hide resolved
@jponge jponge marked this pull request as ready for review May 30, 2024 17:27
@jponge
Copy link
Member Author

jponge commented May 30, 2024

I did a more agressive pruning:

972K	no-deps/target/mutiny-no-deps-999-SNAPSHOT.jar

The best we can do.

/cc @franz1981

@cescoffier
Copy link
Contributor

So basically, we are taking 100K... Not great. However, the result is still less than the sum of the two jars.

@jponge jponge added this to the 2.7.0 milestone Jun 6, 2024
@jponge
Copy link
Member Author

jponge commented Sep 23, 2024

I'm merging this, but this won't be much advertised. Consuming the main mutiny artefact should be the norm, the shaded variant is to be used only if you know what you are doing.

@jponge jponge merged commit 1113f4f into main Sep 23, 2024
6 checks passed
@jponge jponge deleted the feat/no-deps-shading branch September 23, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants