Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: inner subscribers need to be cancelled (flatMap, merge, etc) #1646

Merged
merged 2 commits into from
Jul 11, 2024
Merged

fix: inner subscribers need to be cancelled (flatMap, merge, etc) #1646

merged 2 commits into from
Jul 11, 2024

Conversation

jponge
Copy link
Member

@jponge jponge commented Jul 10, 2024

No description provided.

jponge added 2 commits July 10, 2024 22:05
@jponge
fix(tests): await failures before asserting them
c0f359d 
This fixes timing issues and possibly flaky tests.
@jponge
fix: ensure inner subscribers get cancelled on immediate inner failure
b8c4096 
This has been reported as a discussion in
#1642
@jponge
Copy link
Member Author

jponge commented Jul 10, 2024

See #1642

@jponge jponge added the bug Something isn't working label Jul 10, 2024
@jponge jponge added this to the 2.6.2 milestone Jul 10, 2024
@jponge jponge requested a review from cescoffier July 10, 2024 20:48
@jponge jponge merged commit c0315b2 into main Jul 11, 2024
5 checks passed
@jponge jponge deleted the fix/flatmap-inner-cancellation branch July 11, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cescoffier cescoffier cescoffier approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
2.6.2
Development

Successfully merging this pull request may close these issues.
2 participants
@jponge @cescoffier