-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade the impsort Maven plugin #376
Conversation
The version 1.8.0 is the first version that works correctly with Maven 3.9.0+, see [1][2]. [1] revelc/impsort-maven-plugin#64 [2] revelc/impsort-maven-plugin#65
Hmm, except it requires Java 11... :-/ |
Yes, I noticed the impsort issue yesterday with GH Windows builds. I was wondering why dependabot didn't update the plugin, and I've found this: #338 :D Our plan was to move to 11 with the Jakarta update, which is now done on Quarkus. I think it will be fine to mandate 11 from now on and only update parent in the Jakarta branches (or main if it is already Jakarta). We do need to fix the Maven version in the build pipelines to be able to build the javax versions. |
Hah, I looked for dependabot PR but didn't look far enough into the past :-) Yeah I'm doing the same on Fault Tolerance: merging |
To fix the Maven version in the CI: I think we should merge the Jakarta POM into the main one and drop it, meaning that instead of using @cescoffier Does anyone have any concerns or restrictions? |
I agree with removing the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for us on the Mutiny galaxy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And thank you sir, run into this during my weekend testing and was just about to look where the version is defined :D
The version 1.8.0 is the first version that works correctly with Maven 3.9.0+, see [1][2].
[1] revelc/impsort-maven-plugin#64
[2] revelc/impsort-maven-plugin#65