Use memoize to concurrently cache in ConnectionHolder and RabbitMQConnector
#1447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `RabbitMQConnector` The attempted method of caching used in `ConnectionHolder` and `RabbitMQConnector` is broken. Take `RabbitMQConnector.getSubscriberBuilder` for example, if multiple subscriptions to `getSender` happen before a connection is established it's quite clear that multiple connections will be made; instead of just a single connection. The same issue exists in `ConnectionHolder` in a slightly different fashion. This PR replaces these failed attempts at caching with `Uni.memoize` to serialize and cache properly during concurrent requests.
kdubb
changed the title
memoize to properly serialize & cache in ConnectionHolder and RabbitMQConnectormemoize to concurrently cache in ConnectionHolder and RabbitMQConnector
cescoffier
approved these changes
Oct 8, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1446
The attempted method of caching used in
ConnectionHolderandRabbitMQConnectoris broken.Take
RabbitMQConnector.getSubscriberBuilderfor example, if multiple subscriptions togetSenderhappen before a connection is established it's quite clear that multiple connections will be made; instead of just a single connection.The same issue exists in
ConnectionHolderin a slightly different fashion.This PR replaces these failed attempts at caching with
Uni.memoizeto serialize and cache properly during concurrent requests.