Restore context decorator #2007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ozangunalp
force-pushed
the
restore_context_decorator
branch
from
0d704ad to
b2fee86
Compare
ozangunalp
force-pushed
the
restore_context_decorator
branch
2 times, most recently
from
f3e0fa4 to
0a875ba
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2007 +/- ##
============================================
+ Coverage 77.26% 77.40% +0.13%
- Complexity 3462 3473 +11
============================================
Files 293 294 +1
Lines 11638 11656 +18
Branches 1486 1488 +2
============================================
+ Hits 8992 9022 +30
+ Misses 1948 1942 -6
+ Partials 698 692 -6
|
ozangunalp
force-pushed
the
restore_context_decorator
branch
from
0a875ba to
9e1a587
Compare
cescoffier
previously approved these changes
Dec 8, 2022
| @@ -110,7 +110,7 @@ | |||
| <jandex-maven-plugin.version>1.2.3</jandex-maven-plugin.version> | |||
|
|
|||
| <nats-embedded.version>2.1.0</nats-embedded.version> | |||
| <slf4j-log4j12.version>2.0.5</slf4j-log4j12.version> | |||
| <slf4j-log4j12.version>1.7.36</slf4j-log4j12.version> | |||
There was a problem hiding this comment.
we should ban slf4j 2 for now.
There was a problem hiding this comment.
I've fixed the dependabot config (I think)
cescoffier
approved these changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restores ContextDecorator removed in 3.22.0. Its removal caused stream transformers to dispatch messages on EventLoopContext instead of message duplicated context. See quarkusio/quarkus#23612 (comment)
The removal of ContextDecorator was an attempt to resolve the issue of message drops on Kafka multiple partitions setup. After investigation, the message drops resulted from Mutiny https://github.com/smallrye/smallrye-mutiny/blob/main/implementation/src/main/java/io/smallrye/mutiny/helpers/HalfSerializer.java being called
onItemconcurrently.In order to resolve this, this change removes unnecessary wrappings of Multi`s, which itself wraps subscribers in https://github.com/smallrye/smallrye-mutiny/blob/main/implementation/src/main/java/io/smallrye/mutiny/helpers/StrictMultiSubscriber.java
This change also moves KafkaConnector to the InboundConnector OutboundConnector API which exposes Publisher/Subscribers in Connectors instead of PublisherBuilder and SubscriberBuilder.