Set metrics name for Vertx based clients on mqtt rabbitmq and amqp

[ozangunalp]

So that micrometer metrics will collect metrics for the client.

[codecov-commenter]

Codecov Report

Merging #2034 (9616a5d) into main (46e36d3) will decrease coverage by 0.08%.
The diff coverage is 57.14%.

❗ Current head 9616a5d differs from pull request most recent head 639e875. Consider uploading reports for the commit 639e875 to get more accurate results

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #2034      +/-   ##
============================================
- Coverage     77.25%   77.17%   -0.09%     
- Complexity     3466     3468       +2     
============================================
  Files           294      294              
  Lines         11652    11662      +10     
  Branches       1487     1490       +3     
============================================
- Hits           9002     9000       -2     
- Misses         1954     1961       +7     
- Partials        696      701       +5     

Impacted Files	Coverage Δ
...lrye/reactive/messaging/amqp/AmqpClientHelper.java	70.65% <33.33%> (-1.26%)	⬇️
.../reactive/messaging/mqtt/internal/MqttHelpers.java	51.03% <33.33%> (-0.38%)	⬇️
...ctive/messaging/rabbitmq/RabbitMQClientHelper.java	57.33% <59.37%> (-0.42%)	⬇️
...ka/commit/KafkaThrottledLatestProcessedCommit.java	88.15% <0.00%> (-3.51%)	⬇️
...llrye/reactive/messaging/kafka/impl/KafkaSink.java	92.71% <0.00%> (-1.33%)	⬇️
...reactive/messaging/gcp/pubsub/PubSubConnector.java	46.75% <0.00%> (-1.30%)	⬇️
...rye/reactive/messaging/kafka/impl/KafkaSource.java	84.30% <0.00%> (-0.90%)	⬇️
...ssaging/mqtt/session/MqttClientSessionOptions.java	36.41% <0.00%> (+1.23%)	⬆️
...e/reactive/messaging/amqp/OutgoingAmqpMessage.java	82.60% <0.00%> (+4.34%)	⬆️
...active/messaging/kafka/impl/KafkaRecordStream.java	93.33% <0.00%> (+6.66%)	⬆️
... and 1 more

[ozangunalp]

@cescoffier I've been struggling to test Vert.x net client metrics using micrometer. Am I not supposed to find connection count etc. in the global registry?

[cescoffier]

Not sure about connection count (it's a metric per time window).

Do you have any metrics with the expected prefix?

[ozangunalp]

Ok so it turns out I wasn't configuring Vert.x correctly to enable metrics. With this:

Vertx.vertx(new VertxOptions()
                .setMetricsOptions(new MicrometerMetricsOptions()
                        .setEnabled(true)))

I have meters such as vertx.net.client.active.connections. But I don't see metrics prefixed with the metrics name I set on client creation.

[cescoffier]

You cannot do that - you need to be in Quarkus.

The vert.x micrometer metrics are not reporting the same metrics as (new) quarkus-micrometer. I aligned the reported metrics with the other quarkus-micrometer metrics.

The metrics name using | are read and interpreted by quarkus-micrometer only.

[ozangunalp]

Yes, I later looked the micrometer extension. LGTM with a ad-hoc test.