Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kafka ProducerInterceptor Bean #2059

Merged

Conversation

ozangunalp
Copy link
Collaborator

Kafka connector outgoing channel attribute interceptor-bean for configuring a managed interceptor bean.

@ozangunalp ozangunalp added this to the 3.23.0 milestone Jan 24, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2023

Codecov Report

Merging #2059 (a294d23) into main (46e36d3) will decrease coverage by 65.28%.
The diff coverage is 26.47%.

❗ Current head a294d23 differs from pull request most recent head aff3c11. Consider uploading reports for the commit aff3c11 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##               main    #2059       +/-   ##
=============================================
- Coverage     77.25%   11.97%   -65.28%     
+ Complexity     3466      452     -3014     
=============================================
  Files           294      298        +4     
  Lines         11652    11703       +51     
  Branches       1487     1488        +1     
=============================================
- Hits           9002     1402     -7600     
- Misses         1954    10114     +8160     
+ Partials        696      187      -509     
Impacted Files Coverage Δ
...o/smallrye/reactive/messaging/TracingMetadata.java 0.00% <0.00%> (ø)
...lrye/reactive/messaging/amqp/AmqpClientHelper.java 0.00% <0.00%> (-71.92%) ⬇️
...mallrye/reactive/messaging/amqp/AmqpConnector.java 0.00% <0.00%> (-83.06%) ⬇️
...reactive/messaging/amqp/AmqpCreditBasedSender.java 0.00% <0.00%> (-75.53%) ⬇️
.../smallrye/reactive/messaging/amqp/AmqpMessage.java 0.00% <0.00%> (-95.66%) ⬇️
...essaging/amqp/tracing/AmqpAttributesExtractor.java 0.00% <0.00%> (ø)
...ssaging/amqp/tracing/AmqpMessageTextMapGetter.java 0.00% <0.00%> (ø)
...ssaging/amqp/tracing/AmqpMessageTextMapSetter.java 0.00% <0.00%> (ø)
.../reactive/messaging/kafka/IncomingKafkaRecord.java 72.50% <ø> (-23.25%) ⬇️
...ve/messaging/kafka/fault/KafkaDeadLetterQueue.java 1.49% <ø> (-83.59%) ⬇️
... and 262 more

@ozangunalp ozangunalp force-pushed the kafka_producer_interceptor_bean branch from 3a23d7d to aff3c11 Compare January 25, 2023 11:17
@ozangunalp
Copy link
Collaborator Author

@cescoffier I decided to log and ignore the exceptions as documented in ProducerInterceptor onSend and onAcknowledge methods.

@ozangunalp ozangunalp requested a review from cescoffier January 25, 2023 11:19
@ozangunalp
Copy link
Collaborator Author

Since the update revapi filters behave oddly.

@ozangunalp ozangunalp force-pushed the kafka_producer_interceptor_bean branch from aff3c11 to f476a84 Compare January 25, 2023 11:49
@cescoffier cescoffier merged commit 5fe2696 into smallrye:main Jan 25, 2023
@ozangunalp ozangunalp deleted the kafka_producer_interceptor_bean branch January 25, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants