Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump smallrye-parent from 37 to 38 #2067

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 1, 2023

Bumps smallrye-parent from 37 to 38.

Release notes

Sourced from smallrye-parent's releases.

38

  • #374 Updated Test Plugins
  • #373 Bump testng from 7.6.0 to 7.7.0 in /full-parent-jakarta
  • #371 Bump assertj-core from 3.24.1 to 3.24.2
  • #370 Bump version.junit5 from 5.9.1 to 5.9.2
  • #369 Bump assertj-core from 3.23.1 to 3.24.1
  • #366 Bump versions-maven-plugin from 2.13.0 to 2.14.2
  • #362 Bump maven-install-plugin from 3.0.1 to 3.1.0
  • #361 Bump testcontainers from 1.17.5 to 1.17.6
  • #319 Remove testing dependencies used mostly for MicroProfile TCKs
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Feb 1, 2023
@dependabot dependabot bot requested review from cescoffier and ozangunalp February 1, 2023 21:03
@cescoffier
Copy link
Contributor

Hum... org.jboss.arquillian.container:arquillian-weld-embedded missing??? Let me restart the checks.

@cescoffier
Copy link
Contributor

@radcortez it looks like the new parent declares an unknown version.

@radcortez
Copy link
Member

Yes, this is expected. I've moved all the related TCK stuff to https://github.com/smallrye/smallrye-testing.

Having the Arquillian dependencies in the POM was causing this issue:
smallrye/smallrye-parent#317

The TCK module must refer to the new BOM file from SmallRye Testing. I'll update this.

Bumps [smallrye-parent](https://github.com/smallrye/smallrye-parent) from 37 to 38.
- [Release notes](https://github.com/smallrye/smallrye-parent/releases)
- [Commits](https://github.com/smallrye/smallrye-parent/commits)

---
updated-dependencies:
- dependency-name: io.smallrye:smallrye-parent
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@radcortez radcortez force-pushed the dependabot/maven/main/io.smallrye-smallrye-parent-38 branch from ce69404 to 3a3eaa7 Compare February 2, 2023 11:05
@ozangunalp
Copy link
Collaborator

ozangunalp commented Feb 2, 2023

@radcortez are you sure we should depend on version 1.2.0 instead of 2.2.0 of smallrye-testing-bom-tck?

@radcortez
Copy link
Member

Yes, the 2.x is for Jakarta. I guess the logging utils may work because it doesn't use jakarta packages, but I think its safer this way.

@cescoffier cescoffier merged commit faef5dc into main Feb 2, 2023
@cescoffier cescoffier deleted the dependabot/maven/main/io.smallrye-smallrye-parent-38 branch February 2, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants