-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blocking improvements max-concurrency #2219
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2219 +/- ##
============================================
- Coverage 77.72% 77.72% -0.01%
- Complexity 3695 3737 +42
============================================
Files 301 311 +10
Lines 12307 12458 +151
Branches 1570 1580 +10
============================================
+ Hits 9566 9683 +117
- Misses 2024 2053 +29
- Partials 717 722 +5
|
cescoffier
requested changes
Jul 11, 2023
...er/src/main/java/io/smallrye/reactive/messaging/providers/connectors/WorkerPoolRegistry.java
Outdated
Show resolved
Hide resolved
...ng-provider/src/main/java/io/smallrye/reactive/messaging/providers/i18n/ProviderLogging.java
Outdated
Show resolved
Hide resolved
ozangunalp
force-pushed
the
blocking_improvements
branch
from
July 11, 2023 13:22
a7d89bc
to
d02a5a5
Compare
@cescoffier simplified this PR to use |
cescoffier
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR for discussions
Currently, Reactive Messaging controls the
@Blocking
method max concurrency level using the pool size attribute of the vertx worker pool created for the blocking execution.However, there is a second aspect that affects the max concurrency which is the mutiny concurrency level when merging multiple Uni's into a Multi: https://smallrye.io/smallrye-mutiny/2.3.1/tutorials/transforming-items-asynchronously/#transforming-items-from-multi-the-merge-vs-concatenate-dilemma
This last control how many items will be requested upstream in parallel and effective only when blocking with ordered=false.
This PR changes how the Mutiny merge concurrency is configured :
max-concurrency
is used to configure the Mutiny merge concurrency.Queues.BUFFER_S
.