Pulsar force schema fetch on pulsar-client-thread for all schema requiring schema info fetching #2494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cescoffier
previously approved these changes
Feb 21, 2024
| @@ -115,8 +115,8 @@ public PulsarIncomingChannel(PulsarClient client, Vertx vertx, Schema<T> schema, | |||
| .until(m -> closed.get()) | |||
| .plug(msgMulti -> { | |||
| // Calling getValue on the pulsar-client-internal thread to make sure the SchemaInfo is fetched | |||
| if (schema instanceof AutoConsumeSchema || schema instanceof KeyValueSchema) { | |||
| return msgMulti.onItem().call(msg -> Uni.createFrom().item(msg::getValue)); | |||
| if (schema.requireFetchingSchemaInfo()) { | |||
There was a problem hiding this comment.
The same mechanism should be used for batch see line 141
marekczajkowski
suggested changes
Feb 22, 2024
…iring schema info fetching Fixes smallrye#2493
ozangunalp
force-pushed
the
pulsar_fetch_schema_info
branch
from
bfdbf19 to
545a4c9
Compare
|
@marekczajkowski thanks for pointing it out. I pushed the fix. |
marekczajkowski
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2493