-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic support for AWS SQS - send and read #2500
Conversation
Thanks for your contribution! I've started looking at this and will suggest some changes. |
a1b7f6f
to
5c9af6f
Compare
Here is a proposition for changes to your PoC. It works out of the box with the Quarkus AWS SQS extension It needs some more work like health checks and documentation. @cuichenli could you take a look? |
@ozangunalp thank you for taking the time to review and revamp my PR. I was blown away by the changes you made! Seriously, the work you put into it is nothing short of awesome. And I have to confess, it took me a little while to wrap my head around all the changes you made - especially for the |
29b8b42
to
24a9f24
Compare
@cuichenli thanks for your kind words. I've added some basic docs and I think it is good to go for a first version. Otherwise, I'll proceed to merge it. |
42c13f4
to
974de18
Compare
That's fantastic! Thanks @cuichenli and @ozangunalp ! |
...ctive-messaging-aws-sqs/src/main/java/io/smallrye/reactive/messaging/aws/sqs/SqsMessage.java
Show resolved
Hide resolved
...er/src/main/java/io/smallrye/reactive/messaging/providers/helpers/PausablePollingStream.java
Show resolved
Hide resolved
Uses SqsAsyncClient to interact with SQS API Provider module: - Introduces PausablePollingStream to fetch messages - VertxJsonMapping implementation as a fallback to JsonMapping discovery
974de18
to
01a7440
Compare
Squashed commits |
Hello guys. I would like to know if this AWS SQS Connector is going to be available soon in a final mode or if is it possible to use it right now? Thanks |
Hi team, this is my first PR to this project, please guide me through any project-specific protocols or conventions that I might overlook, 🙇
I noticed there is already one PR to support the AWS SQS but it has been inactive for a while: #2402 hence I created my own implementation here.
Currently, the implementation is in its initial stages and lacks several features. Nevertheless, it successfully supports the fundamental operations—sending and receiving messages to/from AWS SQS—as demonstrated by the included unit tests.
I would love to get feedback on whether the current state of the code aligns with the project's expectations for maturity. If further development is required prior to merging, I am more than willing to continue refining this PR.
Potentially can partially fix: #1117