Improve AMQP Client Shutdown Error Handling #2527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when the AMQP client was closed and the broker was already stopped (such as in Quarkus tests), it resulted in a failure as the client couldn't disconnect properly. This failure was reported by the Mutiny dropped exception handler, potentially causing noise in the logs. This commit introduces a safer approach by ignoring the failure during shutdown. Consequently, this failure will no longer be reported, addressing the potential noise in the logs. Importantly, this behavior only applies during application shutdown, ensuring that it doesn't affect normal operation.
ozangunalp
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when the AMQP client was closed and the broker was already stopped (such as in Quarkus tests), it resulted in a failure as the client couldn't disconnect properly. This failure was reported by the Mutiny dropped exception handler, potentially causing noise in the logs.
This commit introduces a safer approach by ignoring the failure during shutdown. Consequently, this failure will no longer be reported, addressing the potential noise in the logs. Importantly, this behavior only applies during application shutdown, ensuring that it doesn't affect normal operation.