-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JMS: WIP: Initial commit for fault strategies #2599
base: main
Are you sure you want to change the base?
JMS: WIP: Initial commit for fault strategies #2599
Conversation
The build keeps failing here. It works fine when i build it locally. Does anybody have any clues? |
I've only skimmed the change, it looks good. But I need to look into something with how messages are dispatched for JMS connector. I am looking at the CI issues, I hope I found the fix. After that I'll look into this PR. |
dd48f6a
to
549f06e
Compare
That looks good @ozangunalp . I Will take a look at this tommorow. I still need to implement an additional failurestrategy, that is putting the message on a dlq. I just wanted the initial flow working first, and Got a little stück. |
Finally i have had time to look further into this. I have a problem to get the test LocalPropagationAckTest.testChannelWithNackOnMessageContextDlq to work correctly. It is still returning 2,3,3,5,6 and should "only" return 2,3,5,6. I had to pass the JmsConnector into the failure strategy. I am not happy about this, but did not find any other way to do this. Hopefully you guys have some pointers for me, so i can avoid this. |
WIP: Initial commit with 2 simple fault strategies for jms.
I need a little help, creating tests for these. I looked into how it is done for kafka, but it does not look like it can be done the same way here.
Please give me some feedback/hints for this.