Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMQP connector sender reconnects the sender when retrying sends. #2831

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

ozangunalp
Copy link
Collaborator

As the underlying client doesn't ensure any message order among retries, max-inflight-messages attribute is added to control the upstream message requests.

Rewritten the AMQP sender requests using max inflight messages

As the underlying client doesn't ensure any message order among retries,
max-inflight-messages attribute is added to control the upstream message requests.
@ozangunalp ozangunalp merged commit 0f2e4fd into smallrye:main Nov 26, 2024
5 checks passed
@bkalas
Copy link

bkalas commented Nov 26, 2024

@ozangunalp to understand, by releasing that MR with some quarkus version, the bug when emitters stopped sending messages after broker restart should be solved? And the messages which were being send during the broker restart might be nacked? So if we are always waiting for ack/nack of sending message, we should be ok. Or what you ment by that message could be lost?

@ozangunalp
Copy link
Collaborator Author

@bkalas

by releasing that MR with some quarkus version, the bug when emitters stopped sending messages after broker restart should be solved?

Yes, the retry mechanism didn't try to reconnect to the broker and tried using the old connection. It now includes reconnection.

And the messages which were being send during the broker restart might be nacked? So if we are always waiting for ack/nack of sending message, we should be ok

If the retry attempts run out yes, the message will be nacked.

Or what you ment by that message could be lost?

I didn't mean to say the message could be lost, I meant we no longer have the sent message order guarantee in case of retries.

@ozangunalp ozangunalp modified the milestones: 4.26.0-RC3, 4.26.0-RC4, 4.26.0 Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants