Add check for empty DNS value in ca init #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs triage
hslatman
force-pushed
the
herman/fix-empty-dns-init
branch
from
0999f36
to
1664675
Compare
dopey
reviewed
Dec 14, 2022
dopey
previously approved these changes
Dec 14, 2022
dopey
reviewed
Dec 15, 2022
command/ca/init.go
Outdated
| // all are empty (length 0). | ||
| func allEmpty(parts []string) bool { | ||
| for _, p := range parts { | ||
| if len(p) > 0 { |
There was a problem hiding this comment.
Is there a reason we're specifically checking for len here? With strings in golang I thought it was more idiomatic to check if it's equivalent to "".
There was a problem hiding this comment.
Fixed in 3dca2ff. You're right; it's more idiomatic that way.
hslatman
force-pushed
the
herman/fix-empty-dns-init
branch
from
d003588
to
3dca2ff
Compare
dopey
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.