Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix encoding in demo #319

Closed
romanmatyus opened this issue Jul 9, 2020 · 1 comment · Fixed by #342
Closed

Fix encoding in demo #319

romanmatyus opened this issue Jul 9, 2020 · 1 comment · Fixed by #342
Labels
missing or incomplete functionality For something which is not a bug, but more like an incomplete feature. question

Comments

@romanmatyus
Copy link

romanmatyus commented Jul 9, 2020 •
edited
Loading

Please, I have PDF
VysledokAukcie-127691.pdf

Output on demo page it's:

100,00


1


EUR


1589,00


0,00


1589,00


HS technology s.r.o., IČO: 52081061, Sídlo: Fraňa Mojtu 22, 94901 Nitra,
Slovenská republika


99,10
...

My best encoded output it's:

100,00


1


EUR


1589,00


0,00


1589,00


HS technologVUR,26tGOR)UDD0RMWX1LWUD,
 Slovenská republika


99,10

How you encode and write text to html?

Thanks
@k00ni k00ni added missing or incomplete functionality For something which is not a bug, but more like an incomplete feature. question labels Jul 10, 2020
@Connum
Copy link
Contributor

Connum commented Sep 21, 2020 •
edited
Loading

I was able to confirm that this is the same regression introduced by 4f4fd10 as a fix for #260, as in #322!
Prior to that change, the text was decoded properly! (So it seems like the demo page is based on a state prior to that commit, which would explain why it still works in the demo, but not with a more current version)

@Connum Connum mentioned this issue Sep 21, 2020
Closed
@k00ni k00ni mentioned this issue Sep 22, 2020
Closed
Connum added a commit to Connum/pdfparser that referenced this issue Sep 22, 2020
@Connum
revert 4f4fd10 while still preserving the fix for smalot#260, also fi…
9b213dd 
…xing smalot#319, smalot#322 and smalot#334
Connum added a commit to Connum/pdfparser that referenced this issue Sep 22, 2020
@Connum
revert 4f4fd10 preserving fix for smalot#260, fixing smalot#319, smal…
d8bc1b4 
…ot#322 and smalot#334
@Connum Connum mentioned this issue Sep 22, 2020
Merged
@k00ni k00ni linked a pull request Sep 23, 2020 that will close this issue
revert 4f4fd10 preserving fix for #260, fixing #319, #322 and #334 #342
Merged
k00ni pushed a commit that referenced this issue Sep 30, 2020
@Connum
revert 4f4fd10 preserving fix for #260, fixing #319, #322 and #334 (#342
1862686 
)

* Revert "Fix \f crush"

This reverts commit 4f4fd10.

* revert 4f4fd10 preserving fix for #260, fixing #319, #322 and #334

* reduced sample PDF and added more descriptive comment to the two new test cases
partulaj pushed a commit to partulaj/pdfparser that referenced this issue Dec 21, 2020
@Connum @partulaj
revert 4f4fd10 preserving fix for smalot#260, fixing smalot#319, smal…
5e8cea5 
…ot#322 and smalot#334 (smalot#342)

* Revert "Fix \f crush"

This reverts commit 4f4fd10.

* revert 4f4fd10 preserving fix for smalot#260, fixing smalot#319, smalot#322 and smalot#334

* reduced sample PDF and added more descriptive comment to the two new test cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
missing or incomplete functionality For something which is not a bug, but more like an incomplete feature. question
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

revert 4f4fd10 preserving fix for #260, fixing #319, #322 and #334 Connum/pdfparser
3 participants
@k00ni @romanmatyus @Connum