-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement undefined method in Encoding class #378
Implement undefined method in Encoding class #378
Conversation
The __toString method was missing/not implemented, even though it is called in some cases. Fixes #364
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tomlutzenberger Thank you for your contribution!
Can you please fix coding style issues (run vendor/bin/php-cs-fixer fix
) and add at least one test, which demonstrates the original problem and your fix?
Fixes #364
I fixed the issues but was not able to even run the existing tests. It seems PHPUnit is not a dependency and is therefore not found in PHPStorm. |
We use |
It's hard to understand the logic in the Font class without any method documentation, especially the character translation and encoding part. Even though I spent almost all day to get the tests up and running, I wasn't able to write a test due to lack of knowledge about the structure of PDF files 😞 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took the liberty and added a few tests which proof your fix is working. Looks good now. Thank you for your effort.
The __toString method was missing/not implemented, even though it is called in some cases.
Fixes #364