Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encoding::__toString complies with PHP specification from now on #407

Merged
merged 4 commits into from
Apr 13, 2021
Merged

Encoding::__toString complies with PHP specification from now on #407

merged 4 commits into from
Apr 13, 2021

Commits on Apr 6, 2021

  1. Encoding::__toString complies with PHP spec from now on 

    Prior PHP 7.4 we expect an empty string to be returned (based on PHP
specification) when class is invalid.
PHP 7.4+ we expect an exception to be thrown when class is invalid.

Hint came from @igor-krein in
#85 (comment)
    @k00ni
    k00ni committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    2ee0a6f View commit details
    Browse the repository at this point in the history

  2. fixed cs issue

    @k00ni
    k00ni committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    2336c71 View commit details
    Browse the repository at this point in the history

  3. refined Encoding::__toString description

    @k00ni
    k00ni committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    ce6f34b View commit details
    Browse the repository at this point in the history

  4. Update src/Smalot/PdfParser/Encoding.php 

    Co-authored-by: Igor Peisakhovich <igor.krein@gmail.com>
    @k00ni @igor-krein
    k00ni and igor-krein authored Apr 6, 2021
    Configuration menu
    Copy the full SHA
    ee0cf11 View commit details
    Browse the repository at this point in the history