Refactor: declare pdf whitespaces in global variable to avoid bug

[LucianoHanna]

Hi,

I made some refactor in RawDataParser, I declared a global variable containing pdf whitespaces so we don't need to hardcode were use whitespace, avoiding bug if forget to consider all pdf whitespaces

[k00ni]

@LucianoHanna thank you for the PR.

I welcome your changes in general but have to ask you to move $pdfWhitespaces and $pdfWhitespacesRegex to Config.php. Are these the "global" variables you meant in the title?

Its purpose is to hold default values which can be overridden by the user. For some PDFs it may require to change a default value. Here is a basic example how to setup and use Config instance.

Also which bug does this PR avoid?

[k00ni]

Another remark: Please create a separate branch for each pull request in the future. It limits our options if you are using master.

[LucianoHanna]

@k00ni thank you for your remarks!
This PR is a refactor to avoid future bug if some future commit forget to consider all pdf white spaces (like the one fixed in #405)

I refactored the code to remove hardcoded whitespaces and use a config variable, this way we avoid having some line of code considering only %20 as a white space

[LucianoHanna]

@k00ni I made these changes but there's one test failing, maybe should open another PR to remove "CI / Tests alternative autoloader (PHP 5.6)"

[k00ni]

#409 already targets the outdated alternative autoloader tests. Can you merge it and try again? In the end I will squash your PR, so it shouldn't matter

[k00ni]

Good to go 👍🏿

Will merge it soon.

[k00ni]

We had to fix some problems in our testing environment (Github workflow + Scrutinizer). All fixes are now in master. Can you please merge master to see if there are any problems left? Thank you for your patience.

[LucianoHanna]

I merged master and everything looks ok but there's nothing left to commit...

[k00ni]

There should be a merge commit to push. Anyway.