Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix decode octal regex #421

Merged
merged 1 commit into from
May 20, 2021
Merged

Fix decode octal regex #421

merged 1 commit into from
May 20, 2021

Conversation

gdiasb12
Copy link
Contributor

No description provided.

@gdiasb12 gdiasb12 closed this May 14, 2021
@gdiasb12 gdiasb12 deleted the fix/decode-octal-regex branch May 14, 2021 03:47
@gdiasb12 gdiasb12 restored the fix/decode-octal-regex branch May 14, 2021 03:48
@gdiasb12 gdiasb12 deleted the fix/decode-octal-regex branch May 14, 2021 03:53
@gdiasb12 gdiasb12 restored the fix/decode-octal-regex branch May 14, 2021 21:28
@gdiasb12 gdiasb12 reopened this May 14, 2021
k00ni
k00ni reviewed May 15, 2021
View reviewed changes
Copy link
Collaborator

@k00ni k00ni left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

What is the matter with #422? Is this one (#421) your main pull request?

@k00ni k00ni self-assigned this May 15, 2021
@k00ni k00ni added the fix label May 15, 2021
@gdiasb12
Copy link
Contributor Author

Thank you for your contribution!

What is the matter with #422? Is this one (#421) your main pull request?

Sorry about the mess. lol

Yes, the (#421) is the main one.

k00ni
k00ni approved these changes May 18, 2021
View reviewed changes
Copy link
Collaborator

@k00ni k00ni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go. If there aren't any objections I will merge it soon.

@k00ni k00ni merged commit 0aa0180 into smalot:master May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k00ni k00ni k00ni approved these changes

Assignees

@k00ni k00ni

Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gdiasb12 @k00ni