Fixes #478 (/Index problem) #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing problem of incomplete analysis of the /Index entry.
Wrong subdirectory.
Fix problem of uncomplete analysis of /Index entry.
optical changes
optical changes
optical changes
After adding a description to the file, the valid /Index entry now contains two entries (consisting of 2 values: first object number, number of objects): /Index[2 1 21 2]
Adding test for issue 479
Forgot a {
k00ni
reviewed
Nov 11, 2021
Code style update
Added more description and more checks.
Closed
k00ni
requested changes
Nov 12, 2021
optical fix
optical changes
change to remove the native_function_invocation message
Co-authored-by: Konrad Abicht <hi@inspirito.de>
Added comments...
j0k3r
approved these changes
Nov 15, 2021
|
Didn't have much time to look into this, but it seems fine to me - congrats for fixing this @yasheena |
Changes for CS fixer
Comment update
k00ni
reviewed
Nov 16, 2021
Co-authored-by: Konrad Abicht <hi@inspirito.de>
k00ni
approved these changes
Nov 16, 2021
|
Thanks. I've been waiting for this for a long time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the requested pull request from issue #478. Sorry, I was not yet familiar with pull requests.
After editing the document description of a PDF file, I've had some cases where getDetails() stopped reporting the /Info data to the Document class. I found the problem in the incomplete handling of the /Index area. So far it was assumed that the XRef is continuous (only one entry in the area /Index). In my cases there was more than one entry, e.g. "/Index[162 1 165 4]", which means 1 object starting at number 162 and 4 objects starting at number 165. I eliminated this problem in the file "RawDataParser.php" with this pull request.