Deploy latest PHP-CS-Fixer rules (adapted some to match our setup with PHP 7+8) #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Observed changes: * in properties declarations, removed `= null` (no_null_property_initialization) * in methods definitions, replaced `?Type $variable = null` by `Type $variable = null` (nullable_type_declaration_for_default_null_value) * replaced `false !== strpos(…)` by `str_contains(…) (modernize_strpos) * whitespaces changes (operator_linebreak, no_spaces_inside_parenthesis) * replaced `0 !== strpos(…)` by `!str_starts_with(…)` (modernize_strpos)
|
Thank you for taking the time. |
k00ni
changed the title
|
I took the liberty and changed some files. PHP-CS-Fixer was causing problems by enforcing code which is incompatible with PHP 7.x (see changed rules here: https://github.com/smalot/pdfparser/pull/602/files#diff-ef867390e21235c28e24595707bf636e1cc9cad29cf8ee4ac405c564a9facdf6) @Seb35 Any objections or wanna add something? I would like to merge it soon to finish the other PR(s). |
k00ni
approved these changes
Jun 1, 2023
k00ni
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Observed changes:
= null(no_null_property_initialization)?Type $variable = nullbyType $variable = null(nullable_type_declaration_for_default_null_value)false !== strpos(…)by `str_contains(…) (modernize_strpos)0 !== strpos(…)by!str_starts_with(…)(modernize_strpos)Also adapted PHP-CS-Fixer configuration in a way that coding style fixes don't lead to failures when running in PHP 7.x.