Add a pull request template which contains helpful information #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j0k3r
reviewed
Aug 21, 2023
Co-authored-by: Jérémy Benoist <j0k3r@users.noreply.github.com>
Co-authored-by: Jérémy Benoist <j0k3r@users.noreply.github.com>
Co-authored-by: Jérémy Benoist <j0k3r@users.noreply.github.com>
|
@j0k3r can I merge? |
j0k3r
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a pull request template which contains important information about how we do things here. I'm tired of repeating myself all the time 😄, for instance asking people to add at least a unit test. After the merge, when opening the form to create a pull request, the new text will tell people all important things to know before creating a pull request.
My English is not the best, so please don't hesitate to suggest changes!
CC: @GreyWyvern @jzohrab