Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove node v6 and NPM support #193

Closed
smanders opened this issue May 31, 2018 · 4 comments
Closed

remove node v6 and NPM support #193

smanders opened this issue May 31, 2018 · 4 comments
Assignees
Milestone

Comments

@smanders
Copy link
Owner

externpro has some cmake to support webpro (see issue #115)

some cmake functions were migrated from webpro to externpro as part of that work (e45224a)

  • wpPatch (from webpro) integrated into xpPatch with NPM_INSTALL option
  • wpBuildNpmModule renamed to xpBuildNpmModule and slightly modified (NPM_FLAGS)

webpro is migrating away from NPM to yarn... and it makes sense for webpro to be the home for yarn-specific cmake (wpBuildYarnModule, for example) -- and the webpro projects aren't using the NPM_INSTALL option any longer, either...

so this issue is to track removing the NPM support that's in externpro which was added with the commit referenced above

@smanders smanders added this to the next milestone May 31, 2018
@smanders
Copy link
Owner Author

smanders commented May 31, 2018

we also copy NPM into the externpro installer and dedupe it's directory structure to make it all fit in the installer, etc... this should also be able to be removed https://github.com/smanders/externpro/blob/18.04.1/projects/node.cmake#L78-L108 -- but maybe not until we're only building node version 8 and higher... version 8 is what's forced us to migrate from NPM to yarn in webpro and we're still using NPM with our current build of node version 6

@smanders
Copy link
Owner Author

@smanders smanders changed the title remove NPM support remove node v6 and NPM support Jun 12, 2018
@smanders
Copy link
Owner Author

smanders commented Jun 12, 2018

removing node v6 will also help us step closer to supporting Visual Studio 2017 - when attempting to build node v6 with VS2017 there is a message "Looking for Visual Studio 2015 -- Failed to find Visual Studio installation" #189

@smanders smanders modified the milestones: next, current Jun 12, 2018
@smanders smanders mentioned this issue Jun 12, 2018
53 tasks
@smanders smanders self-assigned this Jun 14, 2018
smanders pushed a commit that referenced this issue Jun 14, 2018
@smanders
Copy link
Owner Author

smanders commented Jun 14, 2018

completed with commits referenced above (and below -- remove from projects/README.md)

smanders pushed a commit that referenced this issue Jun 15, 2018
smanders pushed a commit that referenced this issue Aug 3, 2018
* no need for cmake option now that v6 has been removed and we only build v8
* issue #193
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant