Select between ._fit() of .fit() depending on the sklearn version used

[lccatala]

Fixes #15

Scikit-learn changed their API between versions 1.2.2 and 1.3.0, replacing BaseDecisionTree.fit() with BaseDecisionTree._fit().

I check the sklearn.version field before calling one or the other.

[smarie]

Nitpick: readability: please move all new lines after the comment, or all lines before the comment.

[smarie]

Thanks @lccatala !

Although your code does the trick, it would probably be more readable/maintainable to rely on Version. I suggest that you add the two following constants at the top of the file instead :

from packaging.version import Version

SKLEARN_VERSION = Version(sklearn.__version__)
SKLEARN13_OR_GREATER = SKLEARN_VERSION >= Version("1.3.0")

Then you can use SKLEARN13_OR_GREATER in your if test in place of the variable you had created from the version tuple

Thanks !

[smarie]

Also, can you please add a new changelog section 0.3.2 - Fixed compliance with sklearn 1.3.0 containing a single entry with your contribution ? Please look at the previous entries for an example.
Thanks again !

[lccatala]

from packaging.version import Version

SKLEARN_VERSION = Version(sklearn.__version__)
SKLEARN13_OR_GREATER = SKLEARN_VERSION >= Version("1.3.0")

Didn't know that existed, thanks!

[smarie]

All set, thanks @lccatala ! Release 0.3.2 should be available in a few minutes

[smarie]

Release is now available. Thanks a lot !