Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(deid): drop valueString instead of passing it through #364

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(deid): drop valueString instead of passing it through #364

wants to merge 1 commit into from
+59 −58

Commits on Nov 19, 2024

  1. feat(deid): drop valueString instead of passing it through 

    Previously, we would let Observation.valueString (and its component
form) through, optionally masking it with philter if you passed
--philter in.

But it held PHI too often, and if we ever will use the field,
it will likely be via ETL-side NLP. We don't need to keep the string
intact into Athena.

So now, we unconditionally drop Observation.valueString, replacing it
with a data-absent-reason extension marker (so consumers know it
_was_ present).
    @mikix
    mikix committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    741fb34 View commit details
    Browse the repository at this point in the history