custmsg domain chainlink --> platform #901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhuie19
temporarily deployed
to
integration
GitHub Actions
Inactive
patrickhuie19
temporarily deployed
to
integration
GitHub Actions
Inactive
patrickhuie19
temporarily deployed
to
integration
GitHub Actions
Inactive
jmank88
reviewed
Oct 29, 2024
Comment on lines
119
to
121
| "beholder_data_schema", "/beholder-base-message/versions/1", // required | ||
| "beholder_domain", "chainlink", // required | ||
| "beholder_domain", "platform", // required | ||
| "beholder_entity", "BaseMessage", // required |
There was a problem hiding this comment.
Why do we use underscores instead of dot separation for these?
There was a problem hiding this comment.
@cll-gg may know, the naming of these keys was decided by the Beholder team
jmank88
approved these changes
Oct 29, 2024
justinkaseman
approved these changes
Oct 29, 2024
krehermann
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://smartcontract-it.atlassian.net/browse/INFOPLAT-1403