Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/cosmos/txm: use sqlutil.Transact helper #384

Merged
merged 1 commit into from
Nov 14, 2023
Merged

pkg/cosmos/txm: use sqlutil.Transact helper #384

merged 1 commit into from
Nov 14, 2023

Conversation

jmank88
Copy link
Contributor

@jmank88 jmank88 commented Nov 14, 2023

This PR swaps out the custom Transaction helper to use package sqlutil from chainlink-relay instead.

Requires:

cfal
cfal previously approved these changes Nov 14, 2023
patrickhuie19
patrickhuie19 previously approved these changes Nov 14, 2023
vyzaldysanchez
vyzaldysanchez previously approved these changes Nov 14, 2023
@jmank88 jmank88 dismissed stale reviews from vyzaldysanchez, patrickhuie19, and cfal via d07f992 November 14, 2023 17:02
@jmank88 jmank88 marked this pull request as ready for review November 14, 2023 17:03
@cfal cfal merged commit 7ff0bf5 into develop Nov 14, 2023
6 of 14 checks passed
@cfal cfal deleted the sqlutil branch November 14, 2023 17:19
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 0.0% 0.0% Coverage on New Code (is less than 75%)

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants