Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BCI-2623]: removes hardcoded accounts from packages-ts/ #368

Merged
merged 1 commit into from
Mar 7, 2024
Merged

[BCI-2623]: removes hardcoded accounts from packages-ts/ #368

merged 1 commit into from
Mar 7, 2024

Conversation

chris-de-leon-cll
Copy link
Contributor

@chris-de-leon-cll chris-de-leon-cll commented Mar 6, 2024 •
edited
Loading

Please see this ticket for details

In summary:

  • The hardcoded values for devnetPrivateKey and devnetAccount0Address have been removed
  • A starknet test account is now retrieved from the local devnet using a simplified version of this function
  • All references to these hardcoded values have been replaced in packages-ts/

@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 75%)

See analysis details on SonarQube

@chris-de-leon-cll chris-de-leon-cll merged commit 29434ab into develop Mar 7, 2024
15 of 20 checks passed
@chris-de-leon-cll chris-de-leon-cll deleted the feat/BCI-2623-remove-hardcoded-accounts branch March 7, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@archseer archseer archseer approved these changes

@augustbleeds augustbleeds Awaiting requested review from augustbleeds

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chris-de-leon-cll @archseer