Read private ethereum config from env #1151
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.
Why
The changes introduce support for specifying a private Ethereum execution layer, version, and custom Docker images in the test configuration. This allows for greater flexibility and customization when testing against specific or private Ethereum network setups.
What
lib/config/env.go
E2E_TEST_PRIVATE_ETHEREUM_EXECUTION_LAYER
,E2E_TEST_PRIVATE_ETHEREUM_ETHEREUM_VERSION
, andE2E_TEST_PRIVATE_ETHEREUM_CUSTOM_DOCKER_IMAGE
. This allows these configurations to be set through environment variables.TestConfig.ReadFromEnvVar()
to read the new environment variables and set corresponding fields in theTestConfig
struct. This enables the configuration of a private Ethereum network's execution layer, version, and custom Docker images for testing.lib/config/testconfig.go
types
package to use theExecutionLayer
andEthereumVersion
types.ExecutionLayer
andEthereumVersion
types and set them inPrivateEthereumNetwork
config. This allows specifying the execution layer and version for a private Ethereum network.lib/docker/test_env/ethereum_env.go
ethereumVersion
, triggering an attempt to automatically determine the Ethereum version based on the custom Docker image if specified. This enhancement facilitates easier configuration when using custom Ethereum network setups by potentially auto-detecting the correct Ethereum version to use.