Skip to content

Commit

Permalink
Index DON ID in ConfigSet event (#14241)
Browse files Browse the repository at this point in the history
* index DON ID in ConfigSet event

* update wrappers

* Pass empty ID array to the Filter function

---------

Co-authored-by: Bolek Kulbabinski <1416262+bolekk@users.noreply.github.com>
  • Loading branch information
cds95 and bolekk authored Aug 29, 2024
1 parent f7cf307 commit 7c248e7
Show file tree
Hide file tree
Showing 6 changed files with 31 additions and 11 deletions.
5 changes: 5 additions & 0 deletions .changeset/kind-houses-smile.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"chainlink": patch
---

#internal index don ID in ConfigSet event
5 changes: 5 additions & 0 deletions contracts/.changeset/chilled-melons-warn.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@chainlink/contracts': patch
---

#internal index don ID in ConfigSet event
2 changes: 1 addition & 1 deletion contracts/src/v0.8/keystone/CapabilitiesRegistry.sol
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,7 @@ contract CapabilitiesRegistry is OwnerIsCreator, TypeAndVersionInterface {
/// @param donId The ID of the DON the config was set for
/// @param configCount The number of times the DON has been
/// configured
event ConfigSet(uint32 donId, uint32 configCount);
event ConfigSet(uint32 indexed donId, uint32 configCount);

/// @notice This event is emitted when a new node operator is added
/// @param nodeOperatorId The ID of the newly added node operator
Expand Down
2 changes: 1 addition & 1 deletion core/capabilities/ccip/ccip_integration_tests/helpers.go
Original file line number Diff line number Diff line change
Expand Up @@ -562,7 +562,7 @@ func (h *homeChain) AddDON(
iter, err := h.capabilityRegistry.FilterConfigSet(&bind.FilterOpts{
Start: h.backend.Blockchain().CurrentBlock().Number.Uint64() - 1,
End: &endBlock,
})
}, []uint32{})
require.NoError(t, err, "failed to filter config set events")
var donID uint32
for iter.Next() {
Expand Down

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
GETH_VERSION: 1.13.8
capabilities_registry: ../../../contracts/solc/v0.8.24/CapabilitiesRegistry/CapabilitiesRegistry.abi ../../../contracts/solc/v0.8.24/CapabilitiesRegistry/CapabilitiesRegistry.bin 2c8947475e3db9e4feadde2c4325bb093f905e352879518dadac470f33e000ce
capabilities_registry: ../../../contracts/solc/v0.8.24/CapabilitiesRegistry/CapabilitiesRegistry.abi ../../../contracts/solc/v0.8.24/CapabilitiesRegistry/CapabilitiesRegistry.bin cb3e79280a928979bc37de154b12b876996bdbe10f1827e683ee2bfa7a429a6c
feeds_consumer: ../../../contracts/solc/v0.8.24/KeystoneFeedsConsumer/KeystoneFeedsConsumer.abi ../../../contracts/solc/v0.8.24/KeystoneFeedsConsumer/KeystoneFeedsConsumer.bin 8c3a2b18a80be41e7c40d2bc3a4c8d1b5e18d55c1fd20ad5af68cebb66109fc5
forwarder: ../../../contracts/solc/v0.8.24/KeystoneForwarder/KeystoneForwarder.abi ../../../contracts/solc/v0.8.24/KeystoneForwarder/KeystoneForwarder.bin 45d9b866c64b41c1349a90b6764aee42a6d078b454d38f369b5fe02b23b9d16e
ocr3_capability: ../../../contracts/solc/v0.8.24/OCR3Capability/OCR3Capability.abi ../../../contracts/solc/v0.8.24/OCR3Capability/OCR3Capability.bin 8bf0f53f222efce7143dea6134552eb26ea1eef845407b4475a0d79b7d7ba9f8

0 comments on commit 7c248e7

Please sign in to comment.