Remove PriceMin check from attempt builder #14370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amit-momin
reviewed
Sep 9, 2024
amit-momin
reviewed
Sep 9, 2024
|
amit-momin
approved these changes
Sep 11, 2024
huangzhen1997
approved these changes
Sep 12, 2024
akuzni2
pushed a commit
that referenced
this pull request
Sep 13, 2024
* Remove PriceMin check from attempt builder * Remove TipCapMin * Update changeset
DavidOrchard
pushed a commit
that referenced
this pull request
Sep 13, 2024
* Remove PriceMin check from attempt builder * Remove TipCapMin * Update changeset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BCFR-897
Attempt Builder implements a validation check to prevent attempts from being lower than PriceMin. This is an abstraction violation and needs to be dropped. Instead, the limits should be enforceable only on the estimator’s side. Especially given the fact the new FeeHistory estimator doesn’t enforce such a limit.