add new flag, NewHeadsPollInterval #14378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huangzhen1997
changed the base branch from
develop
to
BCFR-706/rpc-client-polling-implementation-of-head-subscriptions
huangzhen1997
changed the base branch from
BCFR-706/rpc-client-polling-implementation-of-head-subscriptions
to
develop
huangzhen1997
changed the base branch from
develop
to
BCFR-706/rpc-client-polling-implementation-of-head-subscriptions
huangzhen1997
requested review from
ilija42,
dhaidashenko and
jmank88
and removed request for
a team and
ilija42
|
huangzhen1997
merged commit d58fe13
into
BCFR-706/rpc-client-polling-implementation-of-head-subscriptions
132 of 133 checks passed
huangzhen1997
deleted the
BCFR-706/adding-a-new-flag-for-NewHeadsPollInterval
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part 1 for supporting http based new block polling over http client. Adding a new flag called
NewHeadsPollInterval, which is an*commonconfig.Duration. And the flag also indicates the NewHeadsPoll is enabled.Tickets:
BCFR-706