Add commit offchain config in OracleCreator #14423
Conversation
Add FeedReaderConfig to Bind all feed addresses for each token in the offchain config
| @@ -109,6 +122,47 @@ var DestReaderConfig = evmrelaytypes.ChainReaderConfig{ | |||
| }, | |||
| }, | |||
| }, | |||
| consts.ContractNameFeeQuoter: { | |||
There was a problem hiding this comment.
moving FeeQuoter from SourceChainConfig to DestChainConfig
asoliman92
requested review from
EasterTheBunny
and removed request for
a team
asoliman92
changed the title
| bcs = append(bcs, types.BoundContract{ | ||
| Address: info.AggregatorAddress, | ||
| Name: consts.ContractNamePriceAggregator, | ||
| }) | ||
| } |
There was a problem hiding this comment.
I feel like we will run into the same issue we did with the offramps, these will have to be re-bound in the chainlink-ccip code because we call GetBindings (I think)
There was a problem hiding this comment.
Since these won't be used for events and just calls, and since we have all the addresses anyway in the plugin, I'm tempted to just do this in the plugin codebase instead and simplify the startup code.
There was a problem hiding this comment.
Why do we bind offramp here then? We bind it again in chainlink-ccip, right?
There was a problem hiding this comment.
Yeah, I think we should revisit this.
asoliman92
force-pushed
the
token-price-integration
branch
from
efd33b1 to
2240a98
Compare
Add FeedReaderConfig to Bind all feed addresses for each token in the offchain config
|
Review this PR commit by commit.
Commits ordered are doing the following:
pluginOracleCreatorpluginOracleCreator. Extract code into smaller functions to make it easier to deal with.