Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use decred secp256k1 directly #14840

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

BabyHalimao
Copy link

@BabyHalimao BabyHalimao commented Oct 18, 2024

Use github.com/decred/dcrd/dcrec/secp256k1/v4 directly rather than github.com/btcsuite/btcd/btcec/v2 which is just a wrapper around the underlying decred library. Inspired by ethereum/go-ethereum#30595

github.com/btcsuite/btcd/btcec/v2 has a very annoying breaking change when upgrading from v2.3.3 to v2.3.4. The easiest way to work around this is to remove the wrapper.

@BabyHalimao BabyHalimao requested review from a team as code owners October 18, 2024 07:54
@BabyHalimao BabyHalimao requested a review from ilija42 October 18, 2024 07:54
Copy link
Contributor

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants