Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unblock core CI by removing Solana setup #14878

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Unblock core CI by removing Solana setup #14878

merged 1 commit into from
Oct 22, 2024
+4 −3

Conversation

ilija42
Copy link
Contributor

@ilija42 ilija42 commented Oct 22, 2024 •
edited
Loading

Resolves

Blocked CI

@ilija42 ilija42 marked this pull request as ready for review October 22, 2024 09:36
@ilija42 ilija42 requested review from a team as code owners October 22, 2024 09:36
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

makramkd
makramkd approved these changes Oct 22, 2024
View reviewed changes
core/cmd/solana_transaction_commands_test.go
@@ -24,6 +24,7 @@ import (
)

func TestShell_SolanaSendSol(t *testing.T) {
t.Skip("solana setup broken due to expired ssl")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫠

@asoliman92 asoliman92 added this pull request to the merge queue Oct 22, 2024
@ilija42 ilija42 removed this pull request from the merge queue due to a manual request Oct 22, 2024
@ilija42 ilija42 added this pull request to the merge queue Oct 22, 2024
@ilija42 ilija42 removed this pull request from the merge queue due to a manual request Oct 22, 2024
@ilija42 ilija42 added this pull request to the merge queue Oct 22, 2024
Merged via the queue into develop with commit f3e66b2 Oct 22, 2024
129 checks passed
@ilija42 ilija42 deleted the unblock-ci branch October 22, 2024 10:50
aalu1418 added a commit that referenced this pull request Oct 22, 2024
@aalu1418
Revert "Unblock core CI by removing Solana setup (#14878)"
600452c 
This reverts commit f3e66b2.
github-merge-queue bot pushed a commit that referenced this pull request Oct 22, 2024
@aalu1418
Solana: re-enable disabled test with updated version (#14892)
fbbda5e 
* Revert "Unblock core CI by removing Solana setup (#14878)"

This reverts commit f3e66b2.

* update solana validator
chainchad pushed a commit that referenced this pull request Oct 22, 2024
@aalu1418 @chainchad
Solana: re-enable disabled test with updated version (#14892)
b27f7e9 
* Revert "Unblock core CI by removing Solana setup (#14878)"

This reverts commit f3e66b2.

* update solana validator

(cherry picked from commit fbbda5e)
0xsuryansh pushed a commit that referenced this pull request Oct 23, 2024
@ilija42 @0xsuryansh
Unblock core CI by removing Solana setup (#14878)
81f49ef
0xsuryansh pushed a commit that referenced this pull request Oct 23, 2024
@aalu1418 @0xsuryansh
Solana: re-enable disabled test with updated version (#14892)
7d32684 
* Revert "Unblock core CI by removing Solana setup (#14878)"

This reverts commit f3e66b2.

* update solana validator
cedric-cordenier pushed a commit that referenced this pull request Oct 24, 2024
@aalu1418 @cedric-cordenier
Solana: re-enable disabled test with updated version (#14892)
b73d475 
* Revert "Unblock core CI by removing Solana setup (#14878)"

This reverts commit f3e66b2.

* update solana validator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@george-dorin george-dorin george-dorin approved these changes

@lukaszcl lukaszcl lukaszcl approved these changes

@mateusz-sekara mateusz-sekara mateusz-sekara approved these changes

@makramkd makramkd makramkd approved these changes

@asoliman92 asoliman92 asoliman92 approved these changes

@chudilka1 chudilka1 Awaiting requested review from chudilka1 chudilka1 is a code owner automatically assigned from smartcontractkit/foundations

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ilija42 @asoliman92 @makramkd @mateusz-sekara @lukaszcl @george-dorin