Config validation requires ws url when http polling disabled #14929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huangzhen1997
changed the title
huangzhen1997
changed the title
huangzhen1997
requested review from
cedric-cordenier,
poopoothegorilla and
dhaidashenko
|
chudilka1
approved these changes
Oct 24, 2024
dhaidashenko
approved these changes
Oct 24, 2024
patrick-dowell
deleted the
BCFR-1067/newHeadPollingInterval-check-when-ws-url-missing
branch
matYang
pushed a commit
to smartcontractkit/ccip
that referenced
this pull request
Nov 14, 2024
Optional WS URL for RPCs to unblock new chain integration. Charry-picks from: smartcontractkit/chainlink#14354 smartcontractkit/chainlink#14373 smartcontractkit/chainlink#14534 smartcontractkit/chainlink#14364 smartcontractkit/chainlink#14929 --------- Co-authored-by: Joe Huang <joe.huang@smartcontract.com>
matYang
added a commit
to smartcontractkit/ccip
that referenced
this pull request
Nov 18, 2024
Optional WS URL for RPCs to unblock new chain integration. Charry-picks from: smartcontractkit/chainlink#14534 smartcontractkit/chainlink#14364 smartcontractkit/chainlink#14929 --------- Co-authored-by: Joe Huang <joe.huang@smartcontract.com> Co-authored-by: Adam Hamrick <adam.hamrick@smartcontract.com> Co-authored-by: Chunkai Yang <matYang@users.noreply.github.com>
This was referenced Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We made WS URL to be optional after we supported HTTP polling. However the http polling requires newHeadPollingInterval flag to be > 0, otherwise ws subscription will be used and ws url can’t be missing.
Add the check in validation function to cover this case
Reference:
https://smartcontract-it.atlassian.net/browse/BCFR-1067